remove Suite.ctx field (unused) #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also reduces the level of abstraction needed on `suite.From()` and `scenario.FromReader()` and `scenario.FromBytes()` so that they return concrete types not interfaces. Only the porcelain `gdt.From()` returns a Runnable interface now. Signed-off-by: Jay Pipes <jaypipes@gmail.com>
jaypipes
added a commit
to jaypipes/gdt-gdt
that referenced
this pull request
Oct 7, 2025
Fixes issue gdt-dev#66 ``` ·> cat ../core/plugin/exec/testdata/pass-on-fail-issue-65.yaml tests: - name: test 1 exec: echo 42 assert: out: is: 24 - name: test 2 exec: echo "meaning of life" assert: out: contains: life ·> ./bin/gdt run ../core/plugin/exec/testdata/pass-on-fail-issue-65.yaml -v === RUN: ../core/plugin/exec/testdata/pass-on-fail-issue-65.yaml --- FAIL: pass-on-fail-issue-65.yaml/test 1 (631.56µs) assertion failed: not in: expected stdout to contain 24 ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── DETAIL ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── [gdt] [pass-on-fail-issue-65.yaml/0:test 1] using timeout of 10s [plugin default] [gdt] [pass-on-fail-issue-65.yaml/0:test 1] exec: echo [42] [gdt] [pass-on-fail-issue-65.yaml/0:test 1] exec: stdout: 42 [gdt] [pass-on-fail-issue-65.yaml/0:test 1] spec/run: single-shot (no retries) ok: false ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── --- PASS: pass-on-fail-issue-65.yaml/test 2 (660.94µs) FAIL ../core/plugin/exec/testdata/pass-on-fail-issue-65.yaml 1.2925ms FAIL ``` Signed-off-by: Jay Pipes <jaypipes@gmail.com>
jaypipes
added a commit
that referenced
this pull request
Oct 7, 2025
uplift to core@1.10.4 and kube@#1.10.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also reduces the level of abstraction needed on
suite.From()andscenario.FromReader()andscenario.FromBytes()so that they return concrete types not interfaces. Only the porcelaingdt.From()returns a Runnable interface now.