Don't export SHELLOPTS#22
Merged
dantesun merged 1 commit intogdubw:masterfrom Oct 13, 2021
guyboltonking:gbk-remove-export-shellopts
Merged
Don't export SHELLOPTS#22dantesun merged 1 commit intogdubw:masterfrom guyboltonking:gbk-remove-export-shellopts
dantesun merged 1 commit intogdubw:masterfrom
guyboltonking:gbk-remove-export-shellopts
Conversation
Exporting SHELLOPTS has the potential to break any shell script invoked by gradle, since any shell script that invokes `set -e` will have that setting exported to _all_ shell scripts invoked as descendant processes, changing behaviour (and in my case, breaking the build).
|
Would it be possible to get a new release with this fix included? It took me a while to understand why a Thanks again for this project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exporting SHELLOPTS has the potential to break any shell script invoked
by gradle, since any shell script that invokes
set -ewill havethat setting exported to all shell scripts invoked as
descendant processes, changing behaviour (and in my case,
breaking the build).