Replace oldstyle function definition #96
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are no longer allowed in C23. Citing the GCC documentation: "An old-style (or “K&R”) function definition is the way function definitions were written in the 1980s. [..] There is no reason to write a definition this way nowadays, but they can still be seen in older GNU programs." https://www.gnu.org/software/c-intro-and-ref/manual/html_node/Old_002dStyle-Function-Definitions.html
Author
|
@ge-ne Do you mind having a look? |
Owner
|
Sorry for the long silence. I have thought about the issue and still have concerns about portability and backwards compatibility. Nevertheless a new release is due for beginning of next year. Till then I will have to come to a decision... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use C89 style. The old style is no longer allowed with C23.