refactor(gtest): Change block execution model in gtest to be similar to the vara-runtime#4119
Merged
Conversation
gtest so it's similar to the vara-runtimegtest to be similar to the vara-runtime
playX18
approved these changes
Aug 12, 2024
ByteNacked
reviewed
Aug 12, 2024
ByteNacked
reviewed
Aug 12, 2024
aeabdb2 to
1867a54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes:
program.send(...)now doesn't trigger block execution.run_next_block,run_next_block_with_allowance,run_to_block. Scheduled tasks can be processed separately without processing messages by callingrun_scheduled_tasks.RunResulta newBlockRunResultis introduced, which gives some report data of the block execution.ProgramAPI is removed as it violates the rules of the runtime: signals are sent only on panic automatically after failed execution, as it's done on the vara runtime (see bcba7c0).TODO:
gtest