Skip to content

refactor(gtest, core): refactor weight dumping, dump additional constants#4148

Merged
StackOverflowExcept1on merged 40 commits into
masterfrom
ap/gtest-auto-weight
Aug 30, 2024
Merged

refactor(gtest, core): refactor weight dumping, dump additional constants#4148
StackOverflowExcept1on merged 40 commits into
masterfrom
ap/gtest-auto-weight

Conversation

@playX18
Copy link
Copy Markdown
Member

@playX18 playX18 commented Aug 13, 2024 •
edited
Loading

~~Some constants are still there, need discussion whether to include them or no such as: EPOCH_DURATION_IN_BLOCKS, EXISTENTIAL_DEPOSIT, GAS_ALLOWANCE,MAILBOX_THRESHOLD, MAX_RESERVATIONS, RESERVE_FOR, VALUE_PER_GAS. We can include them into weight-diff util as well if that's desired. ~~

Me and @StackOverflowExcept1on refactored a lot of code to be more 1-to-1 with pallet gear schedule and core.

  • Added ProcessCosts dump
  • Added DbWeights type to gear pallet, moved read and write fields out of Schedule to DbWeights
  • Moved codegened structures to gear-core
  • Added test to verify correctness of ProcessCosts dump
  • Moved instruction backward compatibility test to vara runtime integration tests

@playX18 playX18 requested a review from breathx August 13, 2024 06:36
@playX18 playX18 self-assigned this Aug 13, 2024
StackOverflowExcept1on
StackOverflowExcept1on reviewed Aug 13, 2024
View reviewed changes
Comment thread utils/weight-diff/src/main.rs Outdated
StackOverflowExcept1on
StackOverflowExcept1on reviewed Aug 13, 2024
View reviewed changes
Comment thread utils/wasm-instrument/src/gas_metering/schedule.rs Outdated
StackOverflowExcept1on
StackOverflowExcept1on reviewed Aug 19, 2024
View reviewed changes
Comment thread utils/weight-diff/src/main.rs Outdated
@playX18 playX18 force-pushed the ap/gtest-auto-weight branch from caa9e48 to 5cacca0 Compare August 20, 2024 03:46
StackOverflowExcept1on
StackOverflowExcept1on reviewed Aug 20, 2024
View reviewed changes
Comment thread pallets/gear/src/schedule.rs Outdated
Comment thread pallets/gear/src/schedule.rs Outdated
Comment thread pallets/gear/src/schedule.rs Outdated
StackOverflowExcept1on
StackOverflowExcept1on reviewed Aug 21, 2024
View reviewed changes
Comment thread gsdk/src/metadata/generated.rs Outdated
@StackOverflowExcept1on StackOverflowExcept1on mentioned this pull request Aug 21, 2024
Closed
StackOverflowExcept1on
StackOverflowExcept1on reviewed Aug 22, 2024
View reviewed changes
Comment thread utils/weight-diff/src/main.rs Outdated
StackOverflowExcept1on
StackOverflowExcept1on reviewed Aug 22, 2024
View reviewed changes
Comment thread utils/weight-diff/src/main.rs Outdated
@playX18 playX18 changed the title chore(gtest): use weights from gear-wasm-instrument instead of hand-crafted constants refactor(gtest, core): refactor weight dumping, dump additional constants Aug 23, 2024
@StackOverflowExcept1on StackOverflowExcept1on merged commit 0a56013 into master Aug 30, 2024
@StackOverflowExcept1on StackOverflowExcept1on deleted the ap/gtest-auto-weight branch August 30, 2024 21:57
@ark0f ark0f mentioned this pull request Jan 13, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breathx breathx breathx approved these changes

@StackOverflowExcept1on StackOverflowExcept1on StackOverflowExcept1on approved these changes

Assignees

@playX18 playX18

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@playX18 @breathx @StackOverflowExcept1on