Skip to content

feat(ethexe/rpc): include user messages in calculateReply#5516

Merged
playX18 merged 6 commits into
masterfrom
ap/calculate-reply-msgs
May 28, 2026
Merged

feat(ethexe/rpc): include user messages in calculateReply#5516
playX18 merged 6 commits into
masterfrom
ap/calculate-reply-msgs

Conversation

@playX18
Copy link
Copy Markdown
Member

@playX18 playX18 commented May 26, 2026

Part of #4691

Summary

Returs messages sent to users inn calculateReply RPC.

How to test

Run test suite or build node & try new RPC endpoint.

Notes

Only for ethexe for now, Vara modification is plannend

Checklist

  • PR title follows Conventional Commits (type(scope): description)
  • Single logical change
  • Tests added or updated (if logic changed)
  • Docs updated (if needed)

@playX18 playX18 added this to the Jun'1'26 - Polish & harden milestone May 26, 2026
@playX18 playX18 self-assigned this May 26, 2026
@playX18 playX18 added type: feat New functionality or user-visible improvement scope: vara.eth Vara Ethereum application layer (L2) ci: full Run full CI matrix (all platforms and profiles) labels May 26, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the calculateReply RPC endpoint to include messages sent to users in its response. By updating the underlying processor and RPC layer to return an ExecuteForReplyOutcome instead of just ReplyInfo, the system now provides better visibility into message flow during program execution. This change is currently scoped to ethexe with plans for future Vara integration.

Highlights

  • RPC Response Update: Updated the calculateReply RPC endpoint to return both the reply information and any messages sent to users, rather than just the reply.
  • Data Structure Changes: Introduced ExecuteForReplyOutcome and CalculateReplyForHandleResult to encapsulate the expanded return data.
  • Test Coverage: Added a new test case overlay_execution_returns_messages_sent_to_users to verify that messages sent to users are correctly captured and returned by the processor.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the execute_for_reply method in ethexe-processor to return both the reply information and any outgoing messages sent to users. It also updates the RPC and SDK layers to handle this new CalculateReplyForHandleResult structure, and adds a test verifying that messages sent to users are correctly returned. The reviewer pointed out an optimization opportunity where program_states can be queried directly using contains_key instead of collecting keys into a temporary vector and performing a linear search, which avoids an unnecessary heap allocation.

Comment thread ethexe/processor/src/lib.rs
@playX18
Copy link
Copy Markdown
Member Author

playX18 commented May 26, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@playX18 playX18 enabled auto-merge May 28, 2026 01:40
@playX18 playX18 added this pull request to the merge queue May 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 28, 2026
@playX18 playX18 added this pull request to the merge queue May 28, 2026
Merged via the queue into master with commit 9a821a8 May 28, 2026
51 checks passed
@playX18 playX18 deleted the ap/calculate-reply-msgs branch May 28, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: full Run full CI matrix (all platforms and profiles) scope: vara.eth Vara Ethereum application layer (L2) type: feat New functionality or user-visible improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants