feat(ethexe/rpc): include user messages in calculateReply#5516
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modifies the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the execute_for_reply method in ethexe-processor to return both the reply information and any outgoing messages sent to users. It also updates the RPC and SDK layers to handle this new CalculateReplyForHandleResult structure, and adds a test verifying that messages sent to users are correctly returned. The reviewer pointed out an optimization opportunity where program_states can be queried directly using contains_key instead of collecting keys into a temporary vector and performing a linear search, which avoids an unnecessary heap allocation.
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Part of #4691
Summary
Returs messages sent to users inn calculateReply RPC.
How to test
Run test suite or build node & try new RPC endpoint.
Notes
Only for ethexe for now, Vara modification is plannend
Checklist
type(scope): description)