Skip to content

Conversation

@StackOverflowExcept1on
Copy link
Member

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @StackOverflowExcept1on, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the sails CLI tool by adding support for generating Ethereum-compatible contracts, primarily for the Vara.ETH ecosystem. It achieves this by introducing a new command-line flag and making necessary adjustments to generated code templates and the client environment to ensure proper functionality and naming conventions for Ethereum-based development.

Highlights

  • New --ethereum flag: Introduced a new --ethereum flag to the sails new command, enabling the generation of contracts compatible with Ethereum (specifically for Vara.ETH).
  • Solidity Name Compatibility: Refactored the default constructor names in generated templates from new() to create() to avoid conflicts with Solidity's new keyword, improving compatibility.
  • Conditional Gas Limit Calculation: Implemented conditional logic for gas limit calculation in the Gclient environment, setting gas_limit to None when the ethexe feature is enabled, which is relevant for Ethereum compatibility.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an --ethereum flag to the sails new command, which enables generation of contracts compatible with Ethereum by conditionally adding the ethexe feature. It also renames the default constructor in templates from new to create to avoid conflicts with the Solidity keyword. The changes are well-implemented, but there is an opportunity to reduce code duplication by extracting a common logic for adding dependencies into a helper function.

@vobradovich vobradovich merged commit 84c1b08 into master Dec 24, 2025
4 checks passed
@vobradovich vobradovich deleted the av/fix-ethexe branch December 24, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants