feat: improve base services routing using message header interface_id

[m62624]

Resolves #1185

[gemini-code-assist]

Summary of Changes

Hello @m62624, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant improvement to how extended services are handled within the framework. The primary goal is to optimize service call dispatch by utilizing the interface_id directly from message headers, thereby eliminating the need for iterative checks across base services. This core change is accompanied by a simplification of From trait implementations for extended services and a refinement of the macro's code generation, including lexicographical sorting of base types and removal of unnecessary use statements, resulting in more efficient and cleaner code.

Highlights

• Optimized Base Service Routing: Implemented direct routing for extended services using interface_id from message headers, replacing sequential checks for improved efficiency in service call dispatch.
• Simplified From Trait Implementations: Refactored From trait implementations for extended services to convert directly to individual base services, enhancing clarity and reducing boilerplate in generated code.
• Lexicographical Sorting of Base Services: Introduced lexicographical sorting of base service types during macro parsing, ensuring consistent ordering and predictable code generation for extended services.
• Code Generation Cleanup: Removed redundant use statements and streamlined generated code for service exposure, contributing to cleaner and more maintainable output.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a significant improvement to the routing mechanism for base services by leveraging the interface_id from the message header. This change enhances performance by avoiding unnecessary conversions to all base services, instead targeting the specific base service indicated by the interface_id. The core logic in the macros has been refactored for better clarity and efficiency, notably by introducing a DispatchParams struct and centralizing the sorting of base service types. A key design change is the shift from a single From<Service> for (Base1, Base2, ...) implementation to individual From<Service> for BaseService implementations, which simplifies the macro's code generation and improves modularity. The snapshot tests and example code have been diligently updated to reflect these changes, ensuring the new implementation is well-tested and documented. Overall, this is a high-quality refactoring that improves both performance and maintainability.

[vobradovich]

LGTM!