feat: migrate metadata from doc-comments to IDL annotations#1301
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request transitions the handling of metadata such as indexed, payable, and returns_value from doc comments to formal attributes (#[type_info(...)]) and IDL annotations (@...). The changes span macro expansion logic, IDL generation, and parsing to ensure consistent use of structured attributes over string-based doc tags. Feedback was provided regarding a function name in rs/macros/core/src/event/ethexe.rs that is now misleading and likely requires a corresponding update to its unit tests.
m62624
force-pushed
the
feat/port-annotations
branch
from
baae75b to
6723d87
Compare
vobradovich
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation uses doc-comment string matching (/// #[payable]) to pass system metadata to generators. This task migrates these to structured annotations (
@payable,@indexed) using thetype-registrysystem to separate human-readable documentation from system-level logic.