Skip to content

feat: add Address type#1313

Merged
m62624 merged 5 commits into
masterfrom
feat/address-ethexe
Apr 22, 2026
Merged

feat: add Address type#1313
m62624 merged 5 commits into
masterfrom
feat/address-ethexe

Conversation

@m62624
Copy link
Copy Markdown
Contributor

@m62624 m62624 commented Apr 21, 2026

Resolves #1262

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Address type to support Solidity-compatible address handling and updates the Solidity contract generator to recognize custom types annotated with @sol_type. The changes include the implementation of the Address struct with relevant traits for ABI encoding and various type conversions, alongside updates to the generator's type resolution logic. Feedback indicates that the current type resolution for @sol_type annotations is limited to top-level named types and should be implemented recursively to support collections such as arrays and slices.

Comment thread rs/sol-gen/src/lib.rs Outdated
@m62624 m62624 marked this pull request as ready for review April 21, 2026 07:31
Comment thread rs/src/lib.rs Outdated
@m62624 m62624 merged commit 10545a2 into master Apr 22, 2026
4 checks passed
@m62624 m62624 deleted the feat/address-ethexe branch April 22, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Address([u8; 20]) and replace direct use of alloy_primitives::Address

2 participants