feat: State trait, pattern, doc, examples#1331
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the State and StateMut traits to abstract over state storage, enabling services to be generic over their state handles. It refactors example services like CounterService and Validator to use these traits, adds comprehensive unit tests, and fixes a recurring typo ("Substract") in IDL and client files. Feedback identifies a breaking change caused by the premature adoption of the Rust 2024 edition in the prelude, a compatibility issue with core::error::Error on older Rust versions, and a suggestion for more explicit dereferencing in the replace_with method.
m62624
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two traits for abstracting over state storage:
State— read access;read(&self) -> Result<impl Deref<Target = Item>, Error>StateMut: State— write access;write(&mut self) -> Result<impl DerefMut<Target = Item>, Error>