feat(sails): Allows to return value with reply from a service#522
Merged
Conversation
Member
Author
|
Awaiting review. Don't merge! |
DennisInSky
reviewed
Sep 20, 2024
Contributor
DennisInSky
left a comment
DennisInSky
left a comment
There was a problem hiding this comment.
Current impl doesn't prevent returning CommandResult from queries
pub fn query(&self) -> CommandResult<u128> {
(123, 100_500).into()
}
Member
Is it necessary to forbid? |
… vo/reply-with-value
DennisInSky
approved these changes
Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #475 .
Introduces special case for handling a
CommandReply<T>as a result type and extracting a value