Avoid type cast warning in build_coder_maps#330
Merged
larskanis merged 1 commit intoged:masterfrom Feb 7, 2020
Merged
Conversation
These columns are of text-like types (name, regproc) which are not mapped. Since they’re ultimately just treated as text, follow our own warning and cast them in SQL to avoid a Ruby type cast warning.
amarshall
force-pushed
the
avoid-typemap-warn
branch
from
5e151e3 to
6ac3de4
Compare
Collaborator
|
LoL! That's the better fix! 😆 |
|
This appears to break redshift. It doesn't like the Here's an example of a commit in another project that removes Monkeypatching this method to revert to the old implementation fixes the issue in our codebase. |
Collaborator
|
@TSMMark Could you please open a new issue for the Redshift incompatibility? I think we can solve it similar to your linked proposal. |
|
@larskanis done #369 thanks for the quick response |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These columns are of text-like types (name, regproc) which are not mapped. Since they’re ultimately just treated as text, follow our own warning and cast them in SQL to avoid a Ruby type cast warning.