Patch 1

[ghost]

Used OSTYPE (since bash) instead of uname to save opening another process.

Avoided awk with standard shell logic, saving another process.

It should now be a little bit simpler to add new OS types to the if statement; just call the function and use upper- or lower-case 'S'. You can use other position parameters in the function for other differences in other OS types.

Root access on different setups may be needed for the -a flag with the passwd command. Using passwd package 1:4.2-3.1ubuntu5.3 on an Ubuntu 16.04.3 setup, I needed root access for the -a flag.

Made the message for users without passwords a more traditional, tidier ERROR message. It might be nice and handy to have a loop iterate over each username to supply both the name and the UID, perhaps other information too.

If you wind up keeping the line which had awk in it, I recommend instead using cut -d " " -f 1 as it's more portable (part of coreutils).

[geekcomputers]

Thank you for you contribution to the repo and the community

…

On 13 Sep 2017, at 17:46, Terminal for Life ***@***.***> wrote: Used OSTYPE (since bash) instead of uname to save opening another process. Avoided awk with standard shell logic, saving another process. It should now be a little bit simpler to add new OS types to the if statement; just call the function and use upper- or lower-case 'S'. You can use other position parameters in the function for other differences in other OS types. Root access on different setups may be needed for the -a flag with the passwd command. Using passwd package 1:4.2-3.1ubuntu5.3 on an Ubuntu 16.04.3 setup, I needed root access for the -a flag. Made the message for users without passwords a more traditional, tidier ERROR message. It might be nice and handy to have a loop iterate over each username to supply both the name and the UID, perhaps other information too. If you wind up keeping the line which had awk in it, I recommend instead using cut -d " " -f 1 as it's more portable (part of coreutils). You can view, comment on, or merge this pull request online at: #1 <#1> Commit Summary Update users_no_password.sh Update users_no_password.sh Update users_no_password.sh Update users_no_password.sh File Changes M users_no_password.sh <https://github.com/geekcomputers/Shell/pull/1/files#diff-0> (32) Patch Links: https://github.com/geekcomputers/Shell/pull/1.patch <https://github.com/geekcomputers/Shell/pull/1.patch> https://github.com/geekcomputers/Shell/pull/1.diff <https://github.com/geekcomputers/Shell/pull/1.diff> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABHa0sDXUJP7c2NWTEDrgdVoXy_kjzDfks5siAbSgaJpZM4PWZ78>.