correction of task3

.gitignore

@@ -1 +1,3 @@
-node_modules
+node_modules
+
+.env

constant.js

@@ -0,0 +1,5 @@
+const REGISTER_URL = "/user/register"
+
+module.exports = {
+    REGISTER_URL
+}

controllers/userController.js

@@ -3,16 +3,11 @@ const bcrypt = require("bcryptjs");
 
 
 
-
 const register_user= async (req,res)=>{
     try {
             const salt = 10;
             const spassword = await bcrypt.hash(req.body.password,salt);
-            const userData=await users.findOne({email:req.body.email})
-            // console.log(userData,"==");
-            if(userData){
-                return res.status(209).send({success:false,msg:"Email already exist"})
-             }else{
+
             let user = new users({
                 username:req.body.username,
                 firstname:req.body.firstname,
@@ -25,9 +20,9 @@ const register_user= async (req,res)=>{
             });
             const user_data = await user.save();
             return res.status(200).send({success:true,data:user_data})
-        }
+            
     } catch (error) {
-        res.status(400).send(error.message)
+        res.status(400).send({success:false,error:error.message})
     }
 }
 

index.js

@@ -1,13 +1,14 @@
+require("dotenv").config()
 const express = require("express");
 const app = express();
 
 require("./dbconnection");
 app.use(express.json())
 const userRoute = require("./routes/register");
 
-app.use("/user/register", userRoute)
+app.use("/user", userRoute)
 
 
-app.listen(3005,()=>{
+app.listen(process.env.PORT_NO,()=>{
     console.log("server is running on port 3005");
 })

middleware/mid_register.js

@@ -0,0 +1,13 @@
+const mongoose = require("mongoose");
+const users = mongoose.model("users" );
+const REG_MIDDLE=async (req,res,next) => {
+    const userData=await users.findOne({email:req.body.email})
+
+            if(userData){
+                return res.status(409).send({success:false,msg:"Email already exist"})
+            }else{
+                next(); 
+            }
+}
+
+module.exports=REG_MIDDLE

package.json

@@ -5,13 +5,14 @@
   "main": "index.js",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",
-    "dev":"nodemon index.js"
+    "dev": "nodemon index.js"
   },
   "author": "",
   "license": "ISC",
   "dependencies": {
     "bcrypt": "^5.1.1",
     "bcryptjs": "^2.4.3",
+    "dotenv": "^16.3.1",
     "express": "^4.18.2",
     "mongoose": "^7.6.3",
     "nodemon": "^3.0.1"

routes/register.js

@@ -1,8 +1,11 @@
 const express = require("express");
+const register_user = require("../controllers/userController");
 const router = express.Router();
 
-const Controller = require("../controllers/userController");
 
-router.post("/",Controller);
+
+const mid_register = require("../middleware/mid_register");
+
+router.post("/register",mid_register,register_user);
 
 module.exports=router;