"Cannot update on a new record object" in created! method

[arsenslyusarchuk]

After creating new record I get the following error

"can not update on a new record object"

My versions of ruby and rails:
ruby 2.0.0p0 (2013-02-24 revision 39474) [x86_64-linux]
Rails 3.2.12

My logs:

activerecord (3.2.12) lib/active_record/persistence.rb:195:in update_column'
workflow (1.0.0) lib/workflow.rb:348:inpersist_workflow_state'
workflow (1.0.0) lib/workflow.rb:214:in process_event!'
workflow (1.0.0) lib/workflow.rb:154:inblock (4 levels) in workflow'
vendor/engines/ads/app/controllers/ads/postings_controller.rb:46:in create'
actionpack (3.2.12) lib/action_controller/metal/implicit_render.rb:4:insend_action'
actionpack (3.2.12) lib/abstract_controller/base.rb:167:in process_action'
actionpack (3.2.12) lib/action_controller/metal/rendering.rb:10:inprocess_action'
actionpack (3.2.12) lib/abstract_controller/callbacks.rb:18:in block in process_action'
activesupport (3.2.12) lib/active_support/callbacks.rb:459:inblock in run_725368758838839659__process_action__1844081299291344106__callbacks'
activesupport (3.2.12) lib/active_support/callbacks.rb:215:in block in _conditional_callback_around_830'
activesupport (3.2.12) lib/active_support/callbacks.rb:326:inaround'
activesupport (3.2.12) lib/active_support/callbacks.rb:310:in _callback_around_785'
activesupport (3.2.12) lib/active_support/callbacks.rb:214:in_conditional_callback_around_830'
activesupport (3.2.12) lib/active_support/callbacks.rb:447:in _run__725368758838839659__process_action__1844081299291344106__callbacks'
activesupport (3.2.12) lib/active_support/callbacks.rb:405:in__run_callback'
activesupport (3.2.12) lib/active_support/callbacks.rb:385:in _run_process_action_callbacks'
activesupport (3.2.12) lib/active_support/callbacks.rb:81:inrun_callbacks'
actionpack (3.2.12) lib/abstract_controller/callbacks.rb:17:in process_action'
actionpack (3.2.12) lib/action_controller/metal/rescue.rb:29:inprocess_action'
actionpack (3.2.12) lib/action_controller/metal/instrumentation.rb:30:in block in process_action'
activesupport (3.2.12) lib/active_support/notifications.rb:123:inblock in instrument'
activesupport (3.2.12) lib/active_support/notifications/instrumenter.rb:20:in instrument'
activesupport (3.2.12) lib/active_support/notifications.rb:123:ininstrument'
actionpack (3.2.12) lib/action_controller/metal/instrumentation.rb:29:in process_action'
actionpack (3.2.12) lib/action_controller/metal/params_wrapper.rb:207:inprocess_action'
activerecord (3.2.12) lib/active_record/railties/controller_runtime.rb:18:in process_action'
actionpack (3.2.12) lib/abstract_controller/base.rb:121:inprocess'
actionpack (3.2.12) lib/abstract_controller/rendering.rb:45:in process'
actionpack (3.2.12) lib/action_controller/metal.rb:203:indispatch'
actionpack (3.2.12) lib/action_controller/metal/rack_delegation.rb:14:in dispatch'
actionpack (3.2.12) lib/action_controller/metal.rb:246:inblock in action'
actionpack (3.2.12) lib/action_dispatch/routing/route_set.rb:73:in call'
actionpack (3.2.12) lib/action_dispatch/routing/route_set.rb:73:indispatch'
actionpack (3.2.12) lib/action_dispatch/routing/route_set.rb:36:in call'
journey (1.0.4) lib/journey/router.rb:68:inblock in call'
journey (1.0.4) lib/journey/router.rb:56:in each'
journey (1.0.4) lib/journey/router.rb:56:incall'
actionpack (3.2.12) lib/action_dispatch/routing/route_set.rb:601:in call'
railties (3.2.12) lib/rails/engine.rb:479:incall'
railties (3.2.12) lib/rails/railtie/configurable.rb:30:in method_missing'
journey (1.0.4) lib/journey/router.rb:68:inblock in call'
journey (1.0.4) lib/journey/router.rb:56:in each'
journey (1.0.4) lib/journey/router.rb:56:incall'
actionpack (3.2.12) lib/action_dispatch/routing/route_set.rb:601:in call'
warden (1.2.1) lib/warden/manager.rb:35:inblock in call'
warden (1.2.1) lib/warden/manager.rb:34:in catch'
warden (1.2.1) lib/warden/manager.rb:34:incall'
actionpack (3.2.12) lib/action_dispatch/middleware/best_standards_support.rb:17:in call'
rack (1.4.5) lib/rack/etag.rb:23:incall'
rack (1.4.5) lib/rack/conditionalget.rb:35:in call'
actionpack (3.2.12) lib/action_dispatch/middleware/head.rb:14:incall'
actionpack (3.2.12) lib/action_dispatch/middleware/params_parser.rb:21:in call'
actionpack (3.2.12) lib/action_dispatch/middleware/flash.rb:242:incall'
rack (1.4.5) lib/rack/session/abstract/id.rb:210:in context'
rack (1.4.5) lib/rack/session/abstract/id.rb:205:incall'
actionpack (3.2.12) lib/action_dispatch/middleware/cookies.rb:341:in call'
activerecord (3.2.12) lib/active_record/query_cache.rb:64:incall'
activerecord (3.2.12) lib/active_record/connection_adapters/abstract/connection_pool.rb:479:in call'
actionpack (3.2.12) lib/action_dispatch/middleware/callbacks.rb:28:inblock in call'
activesupport (3.2.12) lib/active_support/callbacks.rb:405:in _run__4503270357500974277__call__1321220018304606217__callbacks'
activesupport (3.2.12) lib/active_support/callbacks.rb:405:in__run_callback'
activesupport (3.2.12) lib/active_support/callbacks.rb:385:in _run_call_callbacks'
activesupport (3.2.12) lib/active_support/callbacks.rb:81:inrun_callbacks'
actionpack (3.2.12) lib/action_dispatch/middleware/callbacks.rb:27:in call'
actionpack (3.2.12) lib/action_dispatch/middleware/reloader.rb:65:incall'
actionpack (3.2.12) lib/action_dispatch/middleware/remote_ip.rb:31:in call'
actionpack (3.2.12) lib/action_dispatch/middleware/debug_exceptions.rb:16:incall'
actionpack (3.2.12) lib/action_dispatch/middleware/show_exceptions.rb:56:in call'
railties (3.2.12) lib/rails/rack/logger.rb:32:incall_app'
railties (3.2.12) lib/rails/rack/logger.rb:18:in call'
actionpack (3.2.12) lib/action_dispatch/middleware/request_id.rb:22:incall'
rack (1.4.5) lib/rack/methodoverride.rb:21:in call'
rack (1.4.5) lib/rack/runtime.rb:17:incall'
activesupport (3.2.12) lib/active_support/cache/strategy/local_cache.rb:72:in call'
rack (1.4.5) lib/rack/lock.rb:15:incall'
actionpack (3.2.12) lib/action_dispatch/middleware/static.rb:62:in call'
rack-cache (1.2) lib/rack/cache/context.rb:136:inforward'
rack-cache (1.2) lib/rack/cache/context.rb:143:in pass'
rack-cache (1.2) lib/rack/cache/context.rb:155:ininvalidate'
rack-cache (1.2) lib/rack/cache/context.rb:71:in call!'
rack-cache (1.2) lib/rack/cache/context.rb:51:incall'
railties (3.2.12) lib/rails/engine.rb:479:in call'
railties (3.2.12) lib/rails/application.rb:223:incall'
rack (1.4.5) lib/rack/content_length.rb:14:in call'
railties (3.2.12) lib/rails/rack/log_tailer.rb:17:incall'
rack (1.4.5) lib/rack/handler/webrick.rb:59:in service'
/home/aslyusarchuk/.rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/webrick/httpserver.rb:138:inservice'
/home/aslyusarchuk/.rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/webrick/httpserver.rb:94:in run'
/home/aslyusarchuk/.rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/webrick/server.rb:295:inblock in start_thread'

Have you persisted the record yet? if you've only done

p = Posting.new(some_attrs...) 
p.created!

you will get this error, as you can't update a record until you've persisted it. Either .save your record first, or set the state manually using the assignment operator (#=)

This is a limitation of ActiveRecord and how workflow choses to update records. See https://github.com/geekq/workflow/blob/master/lib/workflow/adapters/active_record.rb#L11

[arsenslyusarchuk]

When did you changed functionality of "created!" method? I didn't have to write ".save" before

7e091d8#L0L346

Looks like it used #update_attributes before this, but never #save.

[arsenslyusarchuk]

WTF? It has broken my project. You have to tell about such changes on the topic!!!

Then use an older version or save you records first. This is not a new change, it's two months old. Revert your gem dep to use a version before the change if you can't save the record first. Or fork and do what you want. This is the risk of open source :)

[arsenslyusarchuk]

Thnks for help

[geekq]

I guess we could use an additional if before line 348

7e091d8#L0R348

to differentiate between new records (do nothing in that case, wait for user saving the record in a different way) and existing records (immediately persist).

[geekq]

I'll keep the issue open until

1. we have a minimal unit test for that. Can be based on:

   p = Posting.new(some_attrs...) 
   p.created!
   

2. we have a patch ;-)

Lol, fair enough.

Sent from my iPhone

On Mar 21, 2013, at 12:25 PM, "Vladimir Dobriakov" <notifications@github.commailto:notifications@github.com> wrote:

I'll keep the issue open until

1. we have a minimal unit test for that. Can be based on:

p = Posting.new(some_attrs...)
p.created!

1. we have a patch ;-)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/77#issuecomment-15249160.

[gamov]

Indeed, that would be graceful.

[plukevdh]

There's a two step problem here for AR:

1. We can't do transitions initially when dealing with the current AR persistence strategy because the initial state is not available until persisted. In code, this shows up in the form of a failing spec like so:

  test "state is available on new record before persisting" do
    o = PersistenceTestOrder.new title: "cloud9"
    assert_equal "submitted", o.read_attribute(PersistenceTestOrder.workflow_column)
  end

Failure:
test_state_is_available_on_new_record_before_persisting(PersistenceTest)
<"submitted"> expected but was
<nil>.

2. The second issue is that AR can't update a column on a non-persisted record, as shown by this second spec:

  test 'ensure bang methods can be run when record is not yet persisted' do
    o = PersistenceTestOrder.new title: "cloud9"

    assert_nothing_raised { o.accept! }
    assert "accepted", o.read_attribute(PersistenceTestOrder.workflow_column)
  end

Failure:
test_ensure_bang_methods_can_be_run_when_record_is_not_yet_persisted(PersistenceTest) [/Users/hungerandthirst/Code/Ruby/workflow/test/new_versions/persistence_test.rb:69]:
Exception raised:
<#<ActiveRecord::ActiveRecordError: can not update on a new record object>>.

We have to solve the "initial state before persisted" problem before we can consider being able to perform any of the state change/validation logic.