Skip to content

Conversation

@fhenri
Copy link

@fhenri fhenri commented Jun 16, 2017

vagrant has the possibility to install directly from the Galaxy role file (https://www.vagrantup.com/docs/provisioning/ansible_common.html#galaxy_role_file)

It saves a step from the manual installation step.

I've been interested by Jenkins, but let me know if you want me to review the other files from the repo and I could update if you're ok.

Great job with the ansible roles and those example files

@geerlingguy
Copy link
Owner

Oh, nice! I didn't even notice that feature appear in Vagrant, this looks great. Before I commit it, I'd like to update any of the examples that use the requirements file, just to be consistent. If you can't get around to it, I'll try to do it next time I make the rounds on reviewing PRs in this project.

@fhenri
Copy link
Author

fhenri commented Jul 1, 2017

I've updated the other examples from this repo - I did not test all sub-projects but they all have the same structure
For elk stack, I tested and works ok, the only thing could be to split the requirements file to make 1 specific for log VM and 1 for web. It should be enough to place the installation of galaxy requirement in 1 block but in case you want to create only 1 VM, this would fail. so for now I duplicate the installation of the roles in case you want to create only 1 VM, but ideally, each VM should have its proper requirement file

@geerlingguy
Copy link
Owner

Thanks! I'm sorry it's taken me so long to get to this, but I shall soon.

@stale
Copy link

stale bot commented Mar 6, 2020

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Mar 6, 2020
@stale
Copy link

stale bot commented Apr 5, 2020

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.

@stale stale bot closed this Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants