Replace ronn with ronn-ng + update others#135
Merged
matthewd merged 1 commit intogel-rb:mainfrom Mar 18, 2025
Merged
Conversation
ronn requires hpricot which doesn't seem to build on either Ruby 3.3 or 3.4. Bundler uses ronn-ng so I replaced it with that.
Contributor
Author
|
👋 @matthewd, I'm working on some optimizations in pub_grub for Bundler and wanted to open PRs to keep Gel up to date as well. I'm also happy to submit a PR for the buildkite config but I think I won't be able to run any changes to it. |
Member
|
Thanks! I don't quite recall how much this was me not bothering to fix something that wasn't [quite] broken, vs how much it was about consciously keeping a trickily-shaped dependency (hpricot) as a bonus built-in self-test... but "tricky" != "broken", so either way, this sounds like a good idea now. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ronn requires hpricot which doesn't seem to build for me on either Ruby 3.3 or 3.4. Bundler uses ronn-ng so I replaced it with that.