Conversation
fantix
commented
Sep 5, 2022
fantix
commented
Sep 5, 2022
ec358ff to
813e3fc
Compare
fantix
commented
Sep 6, 2022
29c132a to
f0cf862
Compare
fantix
commented
Sep 8, 2022
Closed
1st1
reviewed
Sep 8, 2022
1st1
reviewed
Sep 8, 2022
1st1
reviewed
Sep 8, 2022
50e26c9 to
ab02fc8
Compare
Member
|
Can you add a comment to the top of generated file like |
dcacf2d to
e79304e
Compare
944c496 to
8b99ab5
Compare
tailhook
reviewed
Oct 10, 2022
d46a21b to
9bb9537
Compare
Pentusha
reviewed
Oct 12, 2022
Pydantic support for edgedb.Range type is not included out of the box
Test case copied from edgedb-go Co-Authored-By: fmoor <fmoor@gmx.com>
1st1
reviewed
Oct 20, 2022
1st1
approved these changes
Oct 20, 2022
Member
1st1
left a comment
There was a problem hiding this comment.
Epic work Fantix. I think this is ready.
fantix
added a commit
that referenced
this pull request
Oct 21, 2022
Changes ======= * Implement dataclass for EdgeObject (#359) (by @fantix in dfb8c8b for #359) * Redo edgedb basic types to inherit from builtin types (#366) (by @fantix in b11b991 for #366) * Officially drop 3.6 support (#373) (by @msullivan in 7b76bc7 for #373) * Support Python 3.11 (#375) (by @msullivan in 04b0da2 for #375) * Codegen with the describe_query() API (#363) (by @fantix in 361221d for #363) * Add codegen docs (#380) (by @colinhacks in 23dd42e for #380) * Use typing_extension.Literal in codegen for Python 3.7 (by @fantix in 6d0d6ab) * Add __all__ to edgedb/__init__.py (by @fmoor in d3ef6d9) Fixes ===== * Improve duration parsing (by @fmoor in 241c80d) * Tweak wording in query_single() error messages (#369) (by @msullivan in e24bb53 for #369) * Fix flake tests on python3.7 (#371) (by @msullivan in 583e1cb for #371) * Don't reject tuple arguments on the client side (#370) (by @msullivan in 09c950f for #370) * Correct edgedb.Client.close() timeout behavior (by @fantix in 33a912c) * Ping first if conn is idle for too long (#365) (by @fantix in 99cf78a for #365) Deprecations ============ * Deprecate object links and simplify link property access (#379) (by @fantix in 2c5dcc7 for #379)
fantix
added a commit
that referenced
this pull request
Oct 21, 2022
Changes ======= * Implement dataclass for EdgeObject (#359) (by @fantix in dfb8c8b for #359) * Redo edgedb basic types to inherit from builtin types (#366) (by @fantix in b11b991 for #366) * Officially drop 3.6 support (#373) (by @msullivan in 7b76bc7 for #373) * Support Python 3.11 (#375) (by @msullivan in 04b0da2 for #375) * Codegen with the describe_query() API (#363) (by @fantix in 361221d for #363) * Add codegen docs (#380) (by @colinhacks in 23dd42e for #380) * Use typing_extension.Literal in codegen for Python 3.7 (by @fantix in 6d0d6ab) * Add __all__ to edgedb/__init__.py (by @fmoor in d3ef6d9) Fixes ===== * Improve duration parsing (by @fmoor in 241c80d) * Tweak wording in query_single() error messages (#369) (by @msullivan in e24bb53 for #369) * Fix flake tests on python3.7 (#371) (by @msullivan in 583e1cb for #371) * Don't reject tuple arguments on the client side (#370) (by @msullivan in 09c950f for #370) * Correct edgedb.Client.close() timeout behavior (by @fantix in 33a912c) * Ping first if conn is idle for too long (#365) (by @fantix in 99cf78a for #365) * Use @-prefixed keys in object codec for link properties (#384) (by @fantix in 68480f9 for #377) Deprecations ============ * Deprecate object links and simplify link property access (#379) (by @fantix in 2c5dcc7 for #379)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review individual commits.
Thearray,set,namedtupleandtupleshould support__deepcopy__()so thatdataclass.asdict()could properly handle theobjectwith such fields.describe_query()APItyping.Literal)geldata/gel#4325 is preferred to generate more friendly code.typing.Optionaleven if the actual cardinality is ONE.edgedb.Rangeis supported, but it doesn't support Pydantic/FastAPI out of the box.Generated sample: