Fix passing type intersections to overloaded functions.#955
Merged
Conversation
msullivan
approved these changes
Oct 28, 2025
| from gel._internal import _typing_inspect | ||
| from gel._internal import _typing_parametric | ||
| from gel._internal._utils import type_repr | ||
| from gel._internal._qbmodel._abstract._methods import BaseGelModelIntersection |
Member
There was a problem hiding this comment.
Could we maybe put some base class for BaseGelModelIntersection in a sibling to _typing_dispatch, instead of adding an import into the bowels of the qbmodel from this otherwise pretty generic code?
dnwpark
force-pushed
the
anytype-type-intersection
branch
from
0553a84 to
aeaea2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes queries such as
std.distinct(default.Foo.is_(default.Bar))