Skip to content

Conversation

@jaclarke
Copy link
Member

@jaclarke jaclarke commented Mar 19, 2025

Runs the ui tests alongside the normal test suite to hopefully catch possible future regressions that break the ui.

@jaclarke jaclarke changed the base branch from master to release/6.x March 19, 2025 17:51
@jaclarke jaclarke changed the base branch from release/6.x to master March 19, 2025 17:52
@jaclarke jaclarke marked this pull request as ready for review March 19, 2025 17:52
@scotttrinh
Copy link
Contributor

I think you want to make this change in https://github.com/geldata/gel/blob/master/.github/workflows.src/tests.tpl.yml and then run the proper make command to generate the the workflow yaml.

Copy link
Member

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's try it

@jaclarke jaclarke merged commit 241fe3e into master Apr 10, 2025
24 checks passed
@jaclarke jaclarke deleted the run-ui-tests branch April 10, 2025 19:02
msullivan added a commit that referenced this pull request Apr 10, 2025
msullivan added a commit that referenced this pull request Apr 10, 2025
This reverts commit 241fe3e.

They were failing due to some CI nonsense I'm not emotionally prepared
to debug today.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants