Support GMPE Tables in Conditional GMPEs#11154
Merged
Conversation
micheles
reviewed
Jan 27, 2026
CB-quakemodel
changed the title
CB-quakemodel
changed the title
CB-quakemodel
commented
Jan 27, 2026
mmpagani
approved these changes
Jan 28, 2026
micheles
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bit tricky because of how the tables are set within the context maker but we need this to ensure NGAEast models (and other GMMS that use tables) are supported as underlying models for conditional GMPEs.
Also fix a typo where
from_mgmpeininit_underlying_gmpesis being set asfrom_mgpmein ModifiableGMPE.A unit test (classical/case_71) using conditional GMPEs with the underlying GMPE being an NGAEast model is added.