IMPACT: set the default maximum_distance based on trt and mag by interpolation#11459
Draft
ptormene wants to merge 12 commits into
Draft
IMPACT: set the default maximum_distance based on trt and mag by interpolation#11459ptormene wants to merge 12 commits into
maximum_distance based on trt and mag by interpolation#11459ptormene wants to merge 12 commits into
Conversation
…trt and mag by interpolation, instead of the usually too big 300km
…ximum_distance based on trt and mag by interpolation
micheles
reviewed
May 15, 2026
| maximum_rupture_depth = valid.Param(valid.floatdict, {}) # km | ||
| maximum_distance = valid.Param(valid.IntegrationDistance.new) # km | ||
| maximum_distance = valid.Param(valid.IntegrationDistance.new, | ||
| calc.filters.DEFAULT_INTEGRATION_DISTANCE) |
Contributor
There was a problem hiding this comment.
For the engine used via the command-line, we DON'T want a default integration distance, we want to force the users to set it explicitly. It is only within OQImpact that we want to have a default integration distance.
Therefore setting the DEFAULT_INTEGRATION_DISTANCE at this level is a no-go.
micheles
reviewed
May 15, 2026
| "Oceanic Crust with Volcanism": "VOLCANIC", | ||
| "Volcanic": "VOLCANIC", | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
This looks very fragile against future changes. At the minimum we need a test at the mosaic level to be able to maintain this mapping and I bet @mmpagani has an idea about the TRTs at the global scale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.