In engine_nightly_test.yml pass --version only if GITHUB_HEAD_REF is not empty #9065
Conversation
| python install.py devel --version=$GITHUB_HEAD_REF --repository=$GITHUB_REPOSITORY | ||
| if [[ "$GITHUB_HEAD_REF" != "" ]] | ||
| then | ||
| ipython install.py devel --version=$GITHUB_HEAD_REF --repository=$GITHUB_REPOSITORY |
There was a problem hiding this comment.
Why ipython and not python?
There was a problem hiding this comment.
thanks, the i was inserted accidentally pressing 'i' to go into VIM insert mode, then the typo was copied also below
| python install.py devel --version=$GITHUB_HEAD_REF --repository=$GITHUB_REPOSITORY | ||
| if [[ "$GITHUB_HEAD_REF" != "" ]] | ||
| then | ||
| ipython install.py devel --version=$GITHUB_HEAD_REF --repository=$GITHUB_REPOSITORY |
| - name: Install dependencies | ||
| run: | | ||
| python install.py devel --version=$GITHUB_HEAD_REF --repository=$GITHUB_REPOSITORY | ||
| if [[ "$GITHUB_HEAD_REF" != "" ]] |
There was a problem hiding this comment.
--repository is a new option available for install.py but there is no documentation about
There was a problem hiding this comment.
This is a very internal variable, used only by us to allow running tests also for PRs created in forks.
| then | ||
| ipython install.py devel --version=$GITHUB_HEAD_REF --repository=$GITHUB_REPOSITORY | ||
| else | ||
| $python install.py devel --repository=$GITHUB_REPOSITORY |
There was a problem hiding this comment.
In this case, the version installed is the latest and not master, should change to:
$python install.py devel --version=master --repository=$GITHUB_REPOSITORY
There was a problem hiding this comment.
For devel and devel_server, master is installed by default, with corresponding requirements
This should fix https://github.com/gem/oq-engine/actions/workflows/engine_nightly_test.yml