Skip to content

Conversation

@dennishahn
Copy link
Contributor

Change the HealthCardResponse and AutCertificateResponse initializer access level to public

Copy link
Contributor

@sigabrtz sigabrtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion there is no real benefit in exposing initializers for these response types (doesn't hurt it much either though). Maybe you can define them in the depending project?

@dennishahn
Copy link
Contributor Author

In my opinion there is no real benefit in exposing initializers for these response types (doesn't hurt it much either though). Maybe you can define them in the depending project?

That seems not to work since that type is a struct with let properties

Copy link
Contributor

@sigabrtz sigabrtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove any keyword. Then we're good to approve/merge.

@sigabrtz
Copy link
Contributor

sigabrtz commented Aug 7, 2024

In my opinion there is no real benefit in exposing initializers for these response types (doesn't hurt it much either though). Maybe you can define them in the depending project?

That seems not to work since that type is a struct with let properties

Interesting. I didn't know that.

@dennishahn dennishahn force-pushed the feature/change_some_initializer_to_be_public branch from 1b1176d to ea36e05 Compare August 8, 2024 15:09
sigabrtz
sigabrtz previously approved these changes Aug 9, 2024
@dennishahn dennishahn force-pushed the feature/change_some_initializer_to_be_public branch 3 times, most recently from 3b634a0 to 2c5a1af Compare August 14, 2024 13:21
…ialiser to be accessible from outside

Changelog: changed
@dennishahn dennishahn force-pushed the feature/change_some_initializer_to_be_public branch from 2c5a1af to 6caa94d Compare August 14, 2024 13:56
@dennishahn dennishahn merged commit a61b610 into main Aug 15, 2024
@dennishahn dennishahn deleted the feature/change_some_initializer_to_be_public branch August 15, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants