Add support to add systemInstruction and update API to V1Beta #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernard-ng
suggested changes
Nov 8, 2024
Comment on lines
+2
to
+7
| <img src="https://raw.githubusercontent.com/alexandrevega/gemini-api-client/main/assets/example.png" width="800" alt="Gemini API PHP Client - Example"> | ||
| </p> | ||
| <p align="center"> | ||
| <a href="https://packagist.org/packages/gemini-api-php/client"><img alt="Total Downloads" src="https://img.shields.io/packagist/dt/gemini-api-php/client"></a> | ||
| <a href="https://packagist.org/packages/gemini-api-php/client"><img alt="Latest Version" src="https://img.shields.io/packagist/v/gemini-api-php/client"></a> | ||
| <a href="https://packagist.org/packages/gemini-api-php/client"><img alt="License" src="https://img.shields.io/github/license/gemini-api-php/client"></a> | ||
| <a href="https://packagist.org/packages/galexandrevega/gemini-api-client"><img alt="Total Downloads" src="https://img.shields.io/packagist/dt/alexandrevega/gemini-api-client"></a> | ||
| <a href="https://packagist.org/packages/alexandrevega/gemini-api-client"><img alt="Latest Version" src="https://img.shields.io/packagist/v/alexandrevega/gemini-api-client"></a> | ||
| <a href="https://packagist.org/packages/alexandrevega/gemini-api-client"><img alt="License" src="https://img.shields.io/github/license/alexandrevega/gemini-api-client"></a> |
There was a problem hiding this comment.
these changes do not apply to this project
Comment on lines
+12
to
+13
| This library is a fork of [gemini-api-php/client](https://github.com/gemini-api-php/client) adding system instructions and updating api to v1beta. | ||
|
|
There was a problem hiding this comment.
these changes do not apply to this project
| _This library is not developed or endorsed by Google._ | ||
|
|
||
| - Erdem Köse - **[github.com/erdemkose](https://github.com/erdemkose)** | ||
| - Alexandre Vega - **[github.com/alexandrevega](https://github.com/alexandrevega)** |
There was a problem hiding this comment.
these changes do not apply to this project
|
|
||
| ```shell | ||
| composer require gemini-api-php/client | ||
| composer require alexandrevega/gemini-api-client |
There was a problem hiding this comment.
these changes do not apply to this project
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "gemini-api-php/client", | |||
| "name": "alexandrevega/gemini-api-client", | |||
There was a problem hiding this comment.
these changes do not apply to this project
Comment on lines
+20
to
+23
| }, | ||
| { | ||
| "name": "Carlos Ramos", | ||
| "email": "contact@cramos.dev" |
There was a problem hiding this comment.
these changes do not apply to this project
| } | ||
|
|
||
| /** | ||
| /**x |
| } | ||
|
|
||
| curl_setopt($ch, CURLOPT_URL, "{$this->baseUrl}/v1/{$request->getOperation()}"); | ||
| curl_setopt($ch, CURLOPT_URL, "{$this->baseUrl}/v1beta/{$request->getOperation()}"); |
Collaborator
|
Thanks for the PR. Fixed in #57 with similar approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for system instruction (using method withSystemInstruction(string $systemInstruction))
Updated url from ´v1´to ´v1beta´ in order to support this feature.
It would be easily adaptable to support multiple system instructions extending the current methods.
This should resolve #46