Skip to content

fix: use tags for codex installation scripts#52

Merged
drosales57 merged 5 commits into
mainfrom
fix/use-tags-codex-install
May 4, 2026
Merged

fix: use tags for codex installation scripts#52
drosales57 merged 5 commits into
mainfrom
fix/use-tags-codex-install

Conversation

@drosales57
Copy link
Copy Markdown
Collaborator

@drosales57 drosales57 commented Apr 30, 2026

Currently the codex installation scripts are installing the latest main commit by default. There's other issues like if the user makes changes to the plugin directory, the git pull will fail because there are uncommitted changes in the directory.

  • updated the codex installation scripts to use a variable that holds the release-tag
  • the scripts use the release tag value to clone specific release tag branch
  • updated README to reference the new command with the tag

other changes to the scripts :

  • getting a shallow clone as we don't need to download the whole git history
  • backing up the existing plugin directory before cloning to start a clean install
  • after cloning, removes the .git folder since we don't need git functionality in the folder

@drosales57 drosales57 requested review from a team as code owners April 30, 2026 21:12
@github-actions github-actions Bot requested a review from chriskinzel April 30, 2026 21:13
@drosales57 drosales57 assigned girish and belluru and unassigned chriskinzel Apr 30, 2026
Copy link
Copy Markdown
Contributor

@belluru belluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By cleaning the plugin directory, we are removing the existing configs such as database_instance_id etc. but if a user is installing latest version of plugin, the overwrite is bound to happen anyways right? Its probably ok, let me know.

@drosales57
Copy link
Copy Markdown
Collaborator Author

By cleaning the plugin directory, we are removing the existing configs such as database_instance_id etc. but if a user is installing latest version of plugin, the overwrite is bound to happen anyways right? Its probably ok, let me know.

yea their existing configs would be overwritten regardless if we have to download the plugin repo again

to do things more safely, instead of deleting the the plugin directory, we can rename it so our changes aren't destructive wdyt?
"${INSTALL_DIR}backup$(date +%Y%m%d%H%M%S)"

@drosales57 drosales57 requested a review from belluru May 4, 2026 21:43
@drosales57 drosales57 merged commit 6cd5114 into main May 4, 2026
10 checks passed
@drosales57 drosales57 deleted the fix/use-tags-codex-install branch May 4, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants