fix: rewrite shell scripts to Node.js for cross-platform compatibility #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gemini-cli-extensions#3 - Windows PowerShell cannot execute .sh scripts without additional tools like Git Bash, WSL, or Cygwin. Changes: - Convert hooks/stop-hook.sh to hooks/stop-hook.js - Convert scripts/cancel.sh to scripts/cancel.js - Convert scripts/setup.sh to scripts/setup.js - Convert tests/hook_test.sh to tests/hook_test.js - Convert tests/setup_test.sh to tests/setup_test.js - Update hooks/hooks.json to reference stop-hook.js - Update commands/ralph/cancel.toml to use node with cancel.js - Update commands/ralph/loop.toml to use node with setup.js - Update README.md to reflect new .js file references All scripts now use Node.js built-in modules (fs, path, child_process) with no external dependencies, ensuring compatibility across Windows, macOS, and Linux platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3 - Windows PowerShell cannot execute .sh scripts without additional tools like Git Bash, WSL, or Cygwin.
Changes:
All scripts now use Node.js built-in modules (fs, path, child_process) with no external dependencies, ensuring compatibility across Windows, macOS, and Linux platforms.