fix: handle npm.cmd on Windows in runCommand#300
Merged
allenhutchison merged 1 commit intogemini-cli-extensions:mainfrom Mar 27, 2026
Merged
fix: handle npm.cmd on Windows in runCommand#300allenhutchison merged 1 commit intogemini-cli-extensions:mainfrom
allenhutchison merged 1 commit intogemini-cli-extensions:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies scripts/start.js to ensure npm commands are correctly executed on Windows by appending the .cmd extension and enabling shell mode. Feedback was provided to improve the robustness of the options object spreading to prevent potential runtime errors if the argument is undefined.
allenhutchison
approved these changes
Mar 27, 2026
Contributor
allenhutchison
left a comment
allenhutchison
left a comment
There was a problem hiding this comment.
LGTM — small, focused Windows fix for the dev startup script. Follows the same pattern used in the upstream gemini-cli repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #299. Using the same pattern as in https://github.com/google-gemini/gemini-cli/blame/104587bae8326e7ad1e2d739b7e14c7665e10b2b/scripts/build_binary.js#L45-L51