This repository was archived by the owner on Sep 21, 2022. It is now read-only.
Conversation
j0tunn
force-pushed
the
fix/disable.rule
branch
from
ca2f74e to
ae8a745
Compare
Contributor
Author
Contributor
There was a problem hiding this comment.
Сразу видно, что PR от Антона ;D
Contributor
|
Кстати, похоже есть 1 кейс, который эту систему поломает:
|
Contributor
|
Оказалось, случай выше учтён, всё работает. Было бы круто сделать для него юнит-тест. |
test/unit/suite-collection.js
Outdated
Contributor
There was a problem hiding this comment.
should fail on attempt to enable unknown suite
Contributor
|
По коду 🆗 |
…field instead of suite.isDisabled function
j0tunn
force-pushed
the
fix/disable.rule
branch
from
ae8a745 to
bfdd6e0
Compare
j0tunn
added a commit
that referenced
this pull request
Jan 22, 2016
SuiteCollection: new enable/disable logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isDisabledfunction generation replaced with one based on existingsuite.browsersfield.browsersadded toStateDisabledSuiteRunnerremoved as now uselessutil.makeSuiteTreehelper for testsutil.makeSuiteStubfixed to return realSuiteobject with all its prototype magic and some stubbed fields