Skip to content

feat: improve calibrator to work correctly on ios simulators and camera cropping logic#1239

Merged
shadowusr merged 2 commits intotestplane@9from
users/shadowusr/TESTPLANE-672.improve-camera-and-calibrator
Apr 18, 2026
Merged

feat: improve calibrator to work correctly on ios simulators and camera cropping logic#1239
shadowusr merged 2 commits intotestplane@9from
users/shadowusr/TESTPLANE-672.improve-camera-and-calibrator

Conversation

@shadowusr
Copy link
Copy Markdown
Member

@shadowusr shadowusr commented Apr 14, 2026

What's done?

  • Calibrator now returns safe area, that can shrink from any side and correctly handles safari on ios simulator behavior
  • Camera now correctly determines if screenshot returned by driver is fullpage and crops it to actual viewport

How new calibration page looks like on ios 26:

Photo viewport-1776088592751-000000

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 98a565b12a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/browser/camera/index.ts
Comment thread src/browser/calibrator.ts
Comment thread src/browser/camera/index.ts
@shadowusr shadowusr force-pushed the users/shadowusr/TESTPLANE-672.composite-image-refactor-and-tests-3 branch from 7de562f to 3268ec2 Compare April 16, 2026 22:06
Base automatically changed from users/shadowusr/TESTPLANE-672.composite-image-refactor-and-tests-3 to testplane@9 April 18, 2026 22:08
@shadowusr shadowusr force-pushed the users/shadowusr/TESTPLANE-672.improve-camera-and-calibrator branch from 7730c91 to 8cc355f Compare April 18, 2026 22:26
@shadowusr
Copy link
Copy Markdown
Member Author

Review issues fixed in e520ffa (part of #1242). Would've been better to have them fixed here, but due to large amount of commits on top of each other, it's more reliable to do it this way =(

@shadowusr shadowusr merged commit 330d518 into testplane@9 Apr 18, 2026
0 of 8 checks passed
@shadowusr shadowusr deleted the users/shadowusr/TESTPLANE-672.improve-camera-and-calibrator branch April 18, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants