Skip to content

feat: allow to extend cli parser via CLI event#202

Merged
j0tunn merged 1 commit intomasterfrom
feat/extandable.cli
Dec 7, 2017
Merged

feat: allow to extend cli parser via CLI event#202
j0tunn merged 1 commit intomasterfrom
feat/extandable.cli

Conversation

@j0tunn
Copy link
Contributor

@j0tunn j0tunn commented Dec 6, 2017

}

constructor(configPath) {
constructor(configPath = defaults.config) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а почему ты решил таки унести это сюда?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

иначе при использовании через API приходится явно указывать конфиг, даже если используется дефолтный. Вообще сюда нужно затащить логику из gemini про поиск дефолтного конфига, но не сейчас

Copy link
Contributor

@eGavr eGavr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onParse вместо addToProcessArgv 👍

@j0tunn j0tunn merged commit ab18e42 into master Dec 7, 2017
@j0tunn j0tunn removed the in progress label Dec 7, 2017
@j0tunn j0tunn deleted the feat/extandable.cli branch December 7, 2017 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants