-
Notifications
You must be signed in to change notification settings - Fork 3
remove bttv refs #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove bttv refs #81
Conversation
Deploying gempbot with
|
| Latest commit: |
03357a0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ba8c4f1d.gempbot.pages.dev |
| Branch Preview URL: | https://bttv-removal.gempbot.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on January 23
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| export function EmotePreview({ emoteId, type }: EmotePreviewProps) { | ||
| if (!emoteId || !emoteId.trim()) { | ||
| const [imageError, setImageError] = useState(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stale image error state persists across emote ID changes
The imageError state is initialized once and never reset when emoteId changes. When a user types an invalid emote ID that fails to load, imageError is set to true. If they then type a valid emote ID, the error state persists and the component displays "error" instead of attempting to load the new emote image. The state needs to be reset (using useEffect or a key) when emoteId or type props change.
| <Text size="xs" ff="monospace" c="dimmed"> | ||
| logged in as{" "} | ||
| <Text span c="white" inherit> | ||
| {scTokenContent?.login || "user"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Property case mismatch causes username display to fail
The code accesses scTokenContent?.login (lowercase l) but the ScTokenContent interface defines the property as Login (capital L). JavaScript property access is case-sensitive, so scTokenContent?.login will always be undefined, causing the fallback value "user" to display instead of the actual username. The access should use scTokenContent?.Login to match the interface definition.
Note
Breaking change: 7TV-only
BttvAdditionalOptions, BTTV reward form, BTTV token accessors, and BTTV handling inEmoteSevenTv*types and parsing (UnmarshallSevenTvAdditionalOptions,SevenTvReward), updates tests accordinglyBackend adjustments
MarshallRewardGetBttvTokenremoved) and related system configUI/UX redesign
Card/Container/Titleusage withBoxand monospace, terminal-style theme (theme.ts,globals.css); styles and notifications unifiedBlocks,Rewards(removes BTTV form;SevenTvFormonly),Permissions,Bot,Sidebar,Teaser,privacypage; tweaks table/actions/pagination labels and sizesBlocks;EmotePreviewandEmotenow 7TV-only URLsTypes/hooks
SevenTv*only; updatesuseChannelPointReward,useUserConfigtypes and consumersWritten by Cursor Bugbot for commit 03357a0. This will update automatically on new commits. Configure here.