Skip to content

[CLN] Replace outputs_centers with outputs in octree access patterns#1090

Merged
Leguark merged 4 commits into
mainfrom
cleaning_engine
Apr 2, 2026
Merged

[CLN] Replace outputs_centers with outputs in octree access patterns#1090
Leguark merged 4 commits into
mainfrom
cleaning_engine

Conversation

@Leguark
Copy link
Copy Markdown
Member

@Leguark Leguark commented Apr 1, 2026

Description

This change refactors the octree output data structure by renaming the outputs_centers attribute to outputs throughout the codebase. The change affects multiple modules including compatibility layers, engine factory, mesh extraction, and test files. Additionally, the debug flag is set to false in several test verification files, and a torch availability check is added to the nugget effect optimization test

Copy link
Copy Markdown
Member Author

Leguark commented Apr 1, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Leguark Leguark marked this pull request as ready for review April 2, 2026 08:19
@Leguark Leguark changed the title [FIX] Replace outputs_centers with outputs across modules for consistency in octree output handling [CLN] Replace outputs_centers with outputs in octree access patterns Apr 2, 2026
@graphite-app graphite-app Bot added the gempy 3 Will come with the next major update label Apr 2, 2026
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Apr 2, 2026

Graphite Automations

"Add gempy label" took an action on this PR • (04/02/26)

1 label was added to this PR based on Miguel de la Varga's automation.

Copy link
Copy Markdown
Member Author

Leguark commented Apr 2, 2026

Merge activity

  • Apr 2, 12:45 PM UTC: Graphite couldn't merge this PR because it failed for an unknown reason (GitHub is reporting that this PR is not mergeable, despite passing required status checks defined by your branch protection rules. Please check your rulesets for additional blocking criteria. Graphite Merge Queue does not currently support rulesets. Please contact Graphite support for further assistance.).

@Leguark Leguark merged commit 61b5af5 into main Apr 2, 2026
2 checks passed
@Leguark Leguark deleted the cleaning_engine branch April 2, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gempy 3 Will come with the next major update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant