[WIP] Development rexview #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name of the function was misleading, it does not write the full data block but only the header. A data block consist of a header and the data, depending on the data itself it can have also sub headers.
This reverts commit e8cc48c
this prevents that api keys are accidentally added to the repository
re-ckart
reviewed
Mar 3, 2020
gempy/addons/RexCloud_Api_key.txt
Outdated
Comment on lines
1
to
4
| 4ffb5ad8-2fb7-4bd1-ae4a-646ee850df66 | ||
| xwYiAn2Fws07pflRPZQoo5yVMkoreFKM | ||
| # put your API tokens and secrets in the lines above. | ||
| # The key file is not tracked in git so it will not be uploaded to the repository. No newline at end of file |
There was a problem hiding this comment.
The comment says that this Key file won't be uploaded but it is in this pull request. It seems that the .gitignore file is wrong here.
Is this your personal API key or just a dummy one?
There was a problem hiding this comment.
You could also include the link https://www.rexos.org/getting-started/ to make it easier for others to generate their own API key
Member
There was a problem hiding this comment.
yes, I was trying to test that gitignore worked, which is clearly not the case :D
…gempy into development_rexview � Conflicts: � gempy/addons/rex_api.py
Member
[CLN] - Deleted prototype code
- Surfaces take the name of the gempy model - Project take the name of the gempy model [TEXT] - plot_ar
- Change requirements.txt for pandas and qgrid
This reverts commit 5524365
This reverts commit 5524365
…velopment_rexview � Conflicts: � .travis.yml � gempy/plot/plot.py � optional-requirements.txt � test/test_addons/test_gempy_to_rexfile.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added materials to rexFiles