Skip to content

Conversation

Leguark
Copy link
Member

@Leguark Leguark commented Sep 24, 2025

Combining centers and corners

This PR refactors the dual contouring implementation to use a more efficient approach for handling grid corners:

  • Adds corners_grid property to EngineGrid to store corner values alongside centers
  • Modifies interpolate_on_octree to compute corners as part of the center grid rather than separately
  • Adds corner-related properties to InterpOutput for accessing corner data
  • Fixes __len__ in RegularGrid to return the correct number of active cells
  • Replaces _get_intersection_on_edges with direct calls to find_intersection_on_edge for improved consistency
  • Updates masking logic to work with the new grid structure
  • Simplifies octree generation by removing redundant corner-related code

These changes improve the efficiency of the dual contouring algorithm by reducing redundant computations and simplifying the data flow.

@Leguark Leguark changed the title [WIP] Combining centers and corners [REFACTOR] Use center grid for dual contouring instead of corners grid Sep 24, 2025
@Leguark Leguark marked this pull request as ready for review September 24, 2025 11:58
@Leguark Leguark changed the base branch from opt_caching to graphite-base/24 September 24, 2025 12:50
@Leguark Leguark changed the base branch from graphite-base/24 to opt_caching September 24, 2025 13:09
@Leguark Leguark changed the base branch from opt_caching to graphite-base/24 September 24, 2025 13:17
@graphite-app graphite-app bot changed the base branch from graphite-base/24 to main September 24, 2025 14:28
Copy link
Member Author

Leguark commented Sep 25, 2025

Merge activity

  • Sep 25, 8:42 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Sep 25, 8:43 AM UTC: @Leguark merged this pull request with Graphite.

@Leguark Leguark merged commit 4e2833d into main Sep 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant