-
Notifications
You must be signed in to change notification settings - Fork 1
[REFACTOR] Use center grid for dual contouring instead of corners grid #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2025
This was referenced Sep 24, 2025
c43a09e to
e5bdf9c
Compare
07c49e7 to
1fc02f8
Compare
e5bdf9c to
0a42019
Compare
…_edge` for improved consistency and simplify edge intersection logic
cad6b64 to
d4419c3
Compare
0a42019 to
8bb7cd5
Compare
8bb7cd5 to
97fa404
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Combining centers and corners
This PR refactors the dual contouring implementation to use a more efficient approach for handling grid corners:
corners_gridproperty toEngineGridto store corner values alongside centersinterpolate_on_octreeto compute corners as part of the center grid rather than separatelyInterpOutputfor accessing corner data__len__inRegularGridto return the correct number of active cells_get_intersection_on_edgeswith direct calls tofind_intersection_on_edgefor improved consistencyThese changes improve the efficiency of the dual contouring algorithm by reducing redundant computations and simplifying the data flow.