-
Notifications
You must be signed in to change notification settings - Fork 1
[ENH] Refactor dual contouring code with improved documentation and modular functions #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2025
This was referenced Sep 24, 2025
afe0898 to
ecd0426
Compare
e5bdf9c to
0a42019
Compare
ecd0426 to
0a0758c
Compare
8bb7cd5 to
97fa404
Compare
0a0758c to
1beeed2
Compare
1beeed2 to
7208c26
Compare
…anced clarity and integration consistency
…euse in dual contouring logic
7208c26 to
6c8e3b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Refactor dual contouring implementation for improved clarity and maintainability
This PR refactors the
dual_contouring_multi_scalarfunction to improve code organization, readability, and maintainability. The changes include:_get_triangulation_codes: Determines appropriate triangulation strategy_validate_stack_relations: Validates stack relation configurations_get_masked_codes: Applies masks to triangulation codes_interp_on_edges: Handles interpolation on edge intersection points_mask_generationwith better documentationThe refactoring preserves all existing functionality while making the code more modular and easier to understand. Edge intersection detection and processing are now more clearly separated, improving the overall architecture.