Skip to content

Conversation

@Leguark
Copy link
Member

@Leguark Leguark commented Oct 9, 2025

Optimize Dual Contouring Vertex Generation and Add Configuration Flag

This PR introduces several optimizations to the dual contouring vertex generation process:

  • Adds a new DUAL_CONTOURING_VERTEX_OVERLAP configuration flag to control vertex overlap behavior
  • Refactors the vertex generation code with significant performance optimizations:
    • Eliminates redundant memory copies and intermediate arrays
    • Improves matrix multiplication efficiency with backend-specific optimizations
    • Enhances voxel filtering logic to only process valid voxels
    • Optimizes mass point calculation with more efficient algorithms
  • Simplifies function interfaces by merging _generate_vertices into generate_dual_contouring_vertices
  • Improves vertex overlap handling with better parameter naming and conditional execution
  • Updates overlap logging to show only relevant keys instead of full data structures

These changes maintain compatibility while improving performance and code clarity in the dual contouring implementation.

@Leguark Leguark force-pushed the optimize_parallel_ branch from ec0d9e4 to ee4bcf8 Compare October 9, 2025 09:09
@Leguark Leguark force-pushed the water_tight_opt branch 2 times, most recently from c208363 to 9e77adf Compare October 9, 2025 09:27
@Leguark Leguark changed the title [WIP] debugging breaking changes in vertex overlap [REFACTOR] Optimize dual contouring vertex generation and add vertex overlap configuration Oct 9, 2025
@Leguark Leguark marked this pull request as ready for review October 9, 2025 10:02
@Leguark Leguark force-pushed the optimize_parallel_ branch from f0fd83c to 4ec0a28 Compare October 9, 2025 10:10
@Leguark Leguark changed the base branch from optimize_parallel_ to graphite-base/36 October 9, 2025 10:23
@graphite-app graphite-app bot changed the base branch from graphite-base/36 to main October 9, 2025 10:27
…mline overlap handling in dual contouring logic
@Leguark Leguark merged commit 98293b5 into main Oct 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants