[REFACTOR] Restructure geophysics input classes for better magnetics and gravity handling #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sor.py - Fix inconsistent tensor type matching for PyTorch tensors. - Enhance error message to include unsupported tensor type details.
- Introduced `GravityInput` and `MagneticsInput` dataclasses to encapsulate related geophysical fields. - Updated `GeophysicsInput` to utilize `GravityInput` and `MagneticsInput` for improved modularity. - Modified `compute_tmi` to accept `MagneticsInput` instead of `GeophysicsInput` for better type specificity. - Adjusted `model_api.py` to align with new `MagneticsInput` structure.
…nes` - Simplified magnetics input condition check in `model_api.py` by replacing `mag_kernel` and `susceptibilities` with `magnetics_input`. - Moved `_direction_cosines` method within `magnetic_gradient.py` for better modularity and code organization.
Leguark
changed the title
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
…r and update initialization logic - Introduced `warnings.warn` to notify usage of deprecated `GeophysicsInput` constructor involving `tz` and `densities`. - Updated `GeophysicsInput` initialization to utilize `GravityInput` and `MagneticsInput` for better modularity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Geophysics Input Structure and Improve Tensor Type Handling
[FIX] Improve tensor type matching and error reporting in backend_tensor.py
[ENH] Refactor magnetics input structure and update TMI computation
GravityInputandMagneticsInputdataclasses to encapsulate related geophysical fieldsGeophysicsInputto utilizeGravityInputandMagneticsInputfor improved modularitycompute_tmito acceptMagneticsInputinstead ofGeophysicsInputfor better type specificitymodel_api.pyto align with newMagneticsInputstructure[ENH] Refactor magnetics input handling and relocate
_direction_cosinesmodel_api.pyby replacingmag_kernelandsusceptibilitieswithmagnetics_input_direction_cosinesmethod withinmagnetic_gradient.pyfor better modularity and code organization