[CLN] Remove unused experimental watertight dual contouring code#52
Merged
[CLN] Remove unused experimental watertight dual contouring code#52
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 13, 2026
Merged
Leguark
force-pushed
the
optimize_evaluation
branch
from
f3de5d0 to
be4c916
Compare
Member
Author
- Deleted `_experimental_water_tight_DC_1.py` and `_interpolate_on_edges.py` as unused and redundant. - Removed references to deprecated watertightness-related debug options. - Cleaned up legacy logic in `multi_scalar_dual_contouring.py`. - Simplified comments and unused code in interpolation features.
- Introduced scalar field sampling and verification for "graben_fault_model" and "simplest_model" tests. - Integrated approval tests with `gempy_verify_array` using `GenericDiffReporter`. - Updated `test_public_interface` and added `_verify_scalar_field` for scalar field validation. - Improved readability and debugging options for scalar field outputs.
…related logic - Deleted `interpolate_single_field` as it was redundant and only used in testing. - Replaced its test references with a local `_interpolate_single_field` helper function. - Refactored and streamlined the `interpolate_scalar_field` logic, moving parts to a new `foo` function for better clarity. - Improved code organization by restructuring imports and removing unused dependencies.
… up related logic - Deleted `_grab_stack_fault_data` as it was redundant and unused. - Adjusted imports to reflect related changes. - Simplified `_interpolate_stack` by removing unnecessary code.
… management - Updated stack structure handling to directly use `stack_structure.stack_number` instead of passing `stack_number`. - Removed redundant conditional in `_multi_scalar_field_manager`. - Streamlined interpolation input creation by eliminating unnecessary function arguments.
…rity and consistency - Renamed `_InterpolationState` to `InterpolationState` and `_process_chunk` to `process_chunk`. - Replaced multiple internal functions (e.g., `compute_weights_for_stacks`, `evaluate`, `segment`) with prefixed counterparts (`_compute_weights_for_stacks`, `_evaluate`, `_segment`) for better encapsulation. - Simplified fault values update logic within `_process_chunk`. - Removed redundant imports and improved type annotations for consistency across modules.
…ation logic - Introduced `_scalar_field_segmentation_v2` for segmentation using an activator interface. - Added `interpolate_feature_with_external_function` to handle external interpolation logic. - Refactored segmentation into a dedicated `_segment` function for clarity and reuse. - Updated `_stack_ops` and `_multi_scalar_field_manager` to support stack-specific interpolation functions and external segmentation.
- Updated `gempy_verify_array` to use `PythonNativeReporter` when running in CI environments. - Retained custom diff tool support for local development with `GenericDiffReporter`.
…ar field interpolation
- Updated `verify` to use a formatted string representation of arrays (`np.array2string`) with precision, separator, and line width for better readability and handling.
Leguark
force-pushed
the
optimize_evaluation
branch
from
56e9c31 to
9aa7aa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[CLN] Remove unused experimental watertight dual contouring code
_experimental_water_tight_DC_1.pyand_interpolate_on_edges.pyas unused and redundant.multi_scalar_dual_contouring.py.[ENH] Add scalar field verification for graben and simplest models
gempy_verify_arrayusingGenericDiffReporter.test_public_interfaceand added_verify_scalar_fieldfor scalar field validation.[CLN] Remove unused import for experimental watertight dual contouring
[CLN] Remove unused function
interpolate_single_fieldand clean up related logicinterpolate_single_fieldas it was redundant and only used in testing._interpolate_single_fieldhelper function.interpolate_scalar_fieldlogic, moving parts to a newfoofunction for better clarity.[WIP] Towards transposing stack loops
[WIP] SPlitting interpolate feature function
[WIP] Adding input classes for the efficient way of compute stacks
[WIP] Working out the loops
[WIP] Running tests
[WIP] Adding logic for solving faults
[CLN] Move functions to each own module
[CLN] Remove unused local function
_grab_stack_fault_dataand clean up related logic_grab_stack_fault_dataas it was redundant and unused._interpolate_stackby removing unnecessary code.[CLN] Refactor stack structure logic and simplify interpolation input management
stack_structure.stack_numberinstead of passingstack_number._multi_scalar_field_manager.[WIP] Debugging interpolation flat
[WIP] Debugging interpolation flat II
[WIP] Fault test runs but with different result
[WIP] Debugging
[WIP] Trying to deal with stacks dependencies
[WIP] Chuncking
[WIP] Tests running
[WIP] cleaning
[ENH] interpolate_stack_flat running
[CLN] Refactor
_stack_opsand_multi_scalar_field_managerfor clarity and consistency_InterpolationStatetoInterpolationStateand_process_chunktoprocess_chunk.compute_weights_for_stacks,evaluate,segment) with prefixed counterparts (_compute_weights_for_stacks,_evaluate,_segment) for better encapsulation._process_chunk.[ENH] Add external interpolation function support and improve segmentation logic
_scalar_field_segmentation_v2for segmentation using an activator interface.interpolate_feature_with_external_functionto handle external interpolation logic._segmentfunction for clarity and reuse._stack_opsand_multi_scalar_field_managerto support stack-specific interpolation functions and external segmentation.