feat(ai-sdk)!: drop the /doctor subpath, decouple from @rudderjs/console (#40)#45
Merged
Conversation
…onsole (#40) Part of the @rudderjs decoupling epic (#35), gemstack side of a coordinated pair (rudder side: rudderjs/rudder#1454). The /doctor module registered an AI doctor check into @rudderjs/console's registry, coupling the agnostic engine to the Rudder CLI. It has moved to @rudderjs/ai/doctor (same import path there). - Deleted src/doctor.ts + src/doctor.test.ts. - Removed the ./doctor entry from package.json exports. - @rudderjs/console peer stays for now (make:agent + /server provider still use it until they relocate; those are deferred in #35). Breaking (0.x minor): import @rudderjs/ai/doctor instead of @gemstack/ai-sdk/doctor. Typecheck + build green; 976 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the
@rudderjsdecoupling epic #35 (the clean part of #40). Gemstack side of a coordinated pair.What
The
/doctormodule registered an AI doctor check into@rudderjs/console's registry - coupling the agnostic engine to the Rudder CLI. It moved to@rudderjs/ai/doctor(same import path there).src/doctor.ts+src/doctor.test.ts../doctorentry frompackage.jsonexports.@rudderjs/consolepeer stays for now:make:agentand the/serverprovider still use it. They (and the/server+ai-evalcouplings to@rudderjs/core) are deferred - they need new gemstack public exports first, per our scoping.Breaking (0.x -> minor)
Import
@rudderjs/ai/doctorinstead of@gemstack/ai-sdk/doctor.Verification
Typecheck + build green; 976 tests pass. Minor changeset included.
(Independent of the still-open ORM-removal PR #44 - disjoint files.)