Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the Orca Whirlpool provider from the swapper package, including its implementation, models, fee logic, and associated tests. Several Solana-related dependencies and utility functions were also removed, and the benchmarking scripts were updated to use stonfi_v2 as the default. Feedback was provided regarding an unused constant in the Solana transaction builder that should be removed as it is now dead code.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the Orca provider from core-ts ahead of moving that implementation to Rust, applies the OKX DEX gas-limit guidance for EVM swaps that require approval, and folds in the currently open dependency update PRs.
Changes
SwapProvider.tsunchanged.@gemwallet/swapper.tx.gasby 50% when returning a provider gas limit for approval-backed swaps.oxlint1.58.0 -> 1.61.0@types/node25.5.0 -> 25.6.0dotenv17.3.1 -> 17.4.2oxfmt0.43.0 -> 0.46.0knip6.3.0 -> 6.6.2Validation
pnpm buildpnpm testpnpm lintpnpm dedupe --checkpnpm install --frozen-lockfile --ignore-scriptsgit diff --checkpnpm --filter @gemwallet/swapper test -- okx/provider.test.tspnpm --filter @gemwallet/swapper buildpnpm --filter @gemwallet/types testpnpm --filter @gemwallet/types buildoxfmt --checkfor touched source filesNotes
The remaining OKX references to Orca are OKX aggregator route metadata, not the removed core-ts Orca provider.