Estimate Sui gas budget dynamically via dry-run#1058
Merged
Conversation
…value Replace the static 25M gas budget with actual estimation using dry-run simulation. Build transactions with a placeholder budget, dry-run to get real gas costs, then rebuild with the correct budget. Pre-built transactions (Swap/Generic) skip the rebuild.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Sui gas budget calculation and transaction building logic, transitioning from a hardcoded gas budget to a dynamic estimation approach using dry runs. Key changes include updating the SuiRpc enum to support optional gas prices and refactoring encoding functions into internal builder patterns. Review feedback identifies a compilation error in preload.rs regarding field access and a potential arithmetic underflow in the gas budget calculation.
gemcoder21
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the static 25M gas budget with actual estimation using dry-run simulation. Build transactions with a placeholder budget, dry-run to get real gas costs, then rebuild with the correct budget. Pre-built transactions (Swap/Generic) skip the rebuild.
Test: