Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new native_asset module to manage tokenized native assets, specifically for Celo, by implementing uses_msg_value and is_tokenized_native functions. This new logic is integrated into the Uniswap V3 and V4 swapper providers and command builders. The changes also include adding constants for Celo USDT and WETH (WCELO) and updating their usage across the codebase. Review feedback indicates that the CELO_USDT_TOKEN_ID constant is misnamed and should be updated to reflect 'Moola cUSD' (mcUSD), and CELO_WETH_TOKEN_ID should be renamed to CELO_WCELO_TOKEN_ID for better clarity, as it refers to Wrapped Celo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.