Bump Gradle image; add consumer ProGuard rules#270
Conversation
Upgrade Gradle base image to gradle:9.0.0-jdk17 to align with AGP 9.x. Enable android.nonFinalResIds=true to support the AGP migration. Add placeholder consumer ProGuard rules for perpetual and referral feature modules. Update reproducible/base_image_tag.txt to reflect the new base image date.
Summary of ChangesHello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating the project's build environment and configuration to prepare for future Android Gradle Plugin (AGP) versions, specifically AGP 9.x. It involves upgrading the Dockerized Gradle environment, adjusting Android resource ID handling, and introducing foundational ProGuard rules for new feature modules to ensure proper obfuscation and shrinking. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Gradle base image to version 9.0.0, enables android.nonFinalResIds for compatibility with newer Android Gradle Plugin versions, and adds placeholder ProGuard consumer rules for several feature modules. The changes are logical and support the migration to AGP 9.x. I have one suggestion regarding a potential typo in a configuration file.
Changes: