Skip to content

Bump Gradle image; add consumer ProGuard rules#270

Merged
gemcoder21 merged 2 commits intomainfrom
codex/bump-base-image-tag-gradle-9
Feb 14, 2026
Merged

Bump Gradle image; add consumer ProGuard rules#270
gemcoder21 merged 2 commits intomainfrom
codex/bump-base-image-tag-gradle-9

Conversation

@0xh3rman
Copy link
Contributor

Changes:

  • Upgrade Gradle base image to gradle:9.0.0-jdk17 to align with AGP 9.x. Enable android.nonFinalResIds=true to support the AGP migration.
  • Add placeholder consumer ProGuard rules for perpetual and referral feature modules.
  • Update reproducible/base_image_tag.txt to reflect the new base image date.

Upgrade Gradle base image to gradle:9.0.0-jdk17 to align with AGP 9.x. Enable android.nonFinalResIds=true to support the AGP migration. Add placeholder consumer ProGuard rules for perpetual and referral feature modules. Update reproducible/base_image_tag.txt to reflect the new base image date.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating the project's build environment and configuration to prepare for future Android Gradle Plugin (AGP) versions, specifically AGP 9.x. It involves upgrading the Dockerized Gradle environment, adjusting Android resource ID handling, and introducing foundational ProGuard rules for new feature modules to ensure proper obfuscation and shrinking.

Highlights

  • Gradle Image Upgrade: The Gradle base image in the Dockerfile was upgraded from gradle:8.13-jdk17 to gradle:9.0.0-jdk17 to align with upcoming AGP 9.x requirements.
  • Android Gradle Plugin Configuration: The android.nonFinalResIds property in gradle.properties was enabled by setting it to true, which is necessary for the AGP migration.
  • ProGuard Rules: Placeholder consumer ProGuard rules files were added for the perpetual and referral feature modules (presents and viewmodels submodules).
  • Base Image Tag Update: The reproducible/base_image_tag.txt file was updated to reflect the new base image date.
  • File Removal: The package-lock.json file was removed from the repository.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Dockerfile
    • Updated the Gradle base image version.
  • features/perpetual/presents/consumer-rules.pro
    • Added a new file for consumer ProGuard rules.
  • features/perpetual/viewmodels/consumer-rules.pro
    • Added a new file for consumer ProGuard rules.
  • features/referral/presents/consumer-rules.pro
    • Added a new file for consumer ProGuard rules.
  • features/referral/viewmodels/consumer-rules.pro
    • Added a new file for consumer ProGuard rules.
  • gradle.properties
    • Enabled the android.nonFinalResIds flag.
  • package-lock.json
    • Removed the file.
  • reproducible/base_image_tag.txt
    • Updated the base image tag date.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Gradle base image to version 9.0.0, enables android.nonFinalResIds for compatibility with newer Android Gradle Plugin versions, and adds placeholder ProGuard consumer rules for several feature modules. The changes are logical and support the migration to AGP 9.x. I have one suggestion regarding a potential typo in a configuration file.

@gemcoder21 gemcoder21 merged commit c84010e into main Feb 14, 2026
3 checks passed
@gemcoder21 gemcoder21 deleted the codex/bump-base-image-tag-gradle-9 branch February 14, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments