Preserve amount field when changing staking validator

[DRadmir]

Fix: #1477

[gemini-code-assist]

Summary of Changes

Hello @DRadmir, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the amount field was inadvertently reset when a user changed their selected staking validator. By preventing the input from being cleared, the user experience for staking operations is significantly improved, allowing for a smoother and more intuitive workflow when adjusting validator choices.

Highlights

• Amount Field Preservation: The cleanInput() call has been removed from the onSelectValidator method in AmountSceneViewModel.swift, ensuring that the amount entered by the user is no longer cleared when a different staking validator is selected.
• New Test Case: A new test case, selectValidatorPreservesAmount, has been added to AmountSceneViewModelTests.swift to explicitly verify that the amount input remains unchanged after selecting a validator.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue where the amount field was cleared when changing the staking validator. The fix is straightforward, involving the removal of the cleanInput() call within onSelectValidator(_:). This correctly preserves the user's input. A new unit test, selectValidatorPreservesAmount, has been added to verify this behavior, which is great. I've suggested a small improvement to the new test to make it more robust by also asserting that the validator has been updated correctly.

[gemini-code-assist]

While the test correctly verifies that the amount is preserved, it doesn't check if the validator was actually updated. Adding an assertion for the validator change would make the test more comprehensive by confirming that onSelectValidator performs its main function correctly while not having unintended side effects.

        #expect(model.stakeValidatorViewModel?.validator == validator2)
        #expect(model.amountInputModel.text == "1.5")

[DRadmir]

@gemcoder21 All other cases work correctly