-
Notifications
You must be signed in to change notification settings - Fork 57
Fix leverage picker crash when opening perpetual position #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Fix array index out of bounds crash in SwiftUI Picker when opening perpetual position - Add `LeverageOption.option(desiredValue:from:)` to select closest valid leverage option - Add unit tests for leverage option selection
Summary of ChangesHello @gemdev111, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request provides a critical fix for a crash that occurred in the SwiftUI Picker when users attempted to open a perpetual position. The core of the solution involves enhancing the leverage option selection mechanism to prevent out-of-bounds errors by always choosing a valid, closest available leverage value. This ensures a more stable and reliable user experience during position opening. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively resolves a crash that occurred when opening a perpetual position by ensuring the selected leverage is always a valid option. The introduction of the LeverageOption.option(desiredValue:from:) method to find the closest available leverage is a solid approach, and it's great to see it backed by a comprehensive set of unit tests. My review includes one suggestion to enhance the readability of the new logic.
Packages/PrimitivesComponents/Sources/Types/LeverageOption.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Refactored LeverageOption.option to select the largest available value not exceeding the desired value, or the minimum if none match. Updated Comparable conformance and adjusted tests to reflect the new selection logic.
LeverageOption.option(desiredValue:from:)to select closest valid leverage optioncloses #1505