Skip to content

Conversation

@gemdev111
Copy link
Contributor

  • Fix array index out of bounds crash in SwiftUI Picker when opening perpetual position
  • Add LeverageOption.option(desiredValue:from:) to select closest valid leverage option
  • Add unit tests for leverage option selection

closes #1505

  - Fix array index out of bounds crash in SwiftUI Picker when opening perpetual position
  - Add `LeverageOption.option(desiredValue:from:)` to select closest valid leverage option
  - Add unit tests for leverage option selection
@gemdev111 gemdev111 self-assigned this Dec 16, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @gemdev111, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a critical fix for a crash that occurred in the SwiftUI Picker when users attempted to open a perpetual position. The core of the solution involves enhancing the leverage option selection mechanism to prevent out-of-bounds errors by always choosing a valid, closest available leverage value. This ensures a more stable and reliable user experience during position opening.

Highlights

  • Crash Fix: Resolved an array index out of bounds crash in the SwiftUI Picker when opening a perpetual position.
  • Leverage Option Selection: Introduced a new static method LeverageOption.option(desiredValue:from:) to intelligently select the closest valid leverage option from a given list.
  • Unit Tests: Added comprehensive unit tests for the new leverage option selection logic to ensure its correctness and robustness.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively resolves a crash that occurred when opening a perpetual position by ensuring the selected leverage is always a valid option. The introduction of the LeverageOption.option(desiredValue:from:) method to find the closest available leverage is a solid approach, and it's great to see it backed by a comprehensive set of unit tests. My review includes one suggestion to enhance the readability of the new logic.

gemdev111 and others added 2 commits December 16, 2025 07:52
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Refactored LeverageOption.option to select the largest available value not exceeding the desired value, or the minimum if none match. Updated Comparable conformance and adjusted tests to reflect the new selection logic.
@gemcoder21 gemcoder21 merged commit 02ba321 into main Dec 17, 2025
3 checks passed
@gemcoder21 gemcoder21 deleted the leverage-selection-crash branch December 17, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash on position openning

3 participants