Enable all unit tests in CI test plan

[DRadmir]

• Add NodeServiceTests and DeviceServiceTests to CI test plan
• Fix SubscriptionServiceTests: update wallet_id to walletId (API change)
• Fix type inference issues in SubscriptionServiceTests

All unit tests now run on CI except:

• WebSocketClientTests (intentionally skipped)
• MarketInsightTests (excluded)

[gemini-code-assist]

Summary of Changes

Hello @DRadmir, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to enhance the reliability of the project's continuous integration pipeline by incorporating additional unit tests for core services. It addresses necessary updates to existing tests to accommodate recent API changes and improves type safety, ensuring that a broader range of functionalities is automatically validated during development.

Highlights

• CI Test Plan Expansion: Added NodeServiceTests and DeviceServiceTests to the continuous integration test plan, significantly increasing test coverage for these service components.
• SubscriptionServiceTests Fixes: Updated SubscriptionServiceTests to reflect an API change, renaming wallet_id to walletId across multiple test cases. This ensures the tests align with the current API specification.
• Type Inference Improvements: Resolved type inference issues within SubscriptionServiceTests, specifically by explicitly referencing Chain.ethereum and using Set for chain comparisons, making the tests more robust and explicit.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• GemTests/unit_frameworks.xctestplan
  • Added NodeServiceTests to the CI test plan.
  • Added DeviceServiceTests to the CI test plan.
• Packages/FeatureServices/DeviceService/Tests/SubscriptionServiceTests.swift
  • Updated all instances of wallet_id to walletId to match an API change.
  • Corrected type inference for chain comparisons by explicitly using Chain.ethereum.
  • Improved chain comparison logic by using Set for unordered collections.

Activity

• DRadmir created this pull request to enable more unit tests in CI and fix related issues.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully enables more unit tests in the CI test plan by adding NodeServiceTests and DeviceServiceTests. It also includes necessary fixes for SubscriptionServiceTests to address an API change (renaming wallet_id to walletId) and resolve type inference issues, which allows the tests to compile and run correctly. The changes are solid and achieve the goal of increasing test coverage in CI. I've added one suggestion to improve the maintainability of the test code by reducing duplication.