Use recommended validator set; add TestKit mock

[DRadmir]

Replace random selection in recommendedCurrentValidator with a deterministic lookup using recommendedValidators.validatorsSet. Add a new StakeSceneViewModel+TestKit.swift providing a mock factory for tests. Update StakeSceneViewModelTests to use the TestKit, adjust imports, remove the inline mock/TODO, and add a unit test for recommendedCurrentValidator to assert the correct validator is returned.

Fix: #1763

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the validator selection mechanism within the staking feature by transitioning from a random approach to a deterministic lookup based on a predefined set of recommended validators. Concurrently, it significantly enhances the testability of the StakeSceneViewModel by introducing a dedicated TestKit mock factory, which is then integrated into the existing test suite, along with a new test case to validate the updated validator selection logic.

Highlights

• Deterministic Validator Selection: The logic for recommendedCurrentValidator in StakeSceneViewModel was updated to deterministically select a validator from recommendedValidators.validatorsSet instead of using a random selection method.
• TestKit Introduction: A new StakeSceneViewModel+TestKit.swift file was added, providing a dedicated mock factory for StakeSceneViewModel to enhance testability and simplify test setup.
• Test Suite Refinement: The StakeSceneViewModelTests were refactored to utilize the newly introduced TestKit mock factory, remove an outdated inline mock, and include a new unit test to specifically verify the correct deterministic selection of the recommended validator.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• Features/Stake/Sources/ViewModels/StakeSceneViewModel.swift
  • Modified recommendedCurrentValidator to use recommendedValidators.validatorsSet(chain:) and validators.first { ids.contains($0.id) } for deterministic selection.
• Features/Stake/TestKit/StakeSceneViewModel+TestKit.swift
  • Added a new file containing a StakeSceneViewModel extension with a static mock factory method for test purposes.
• Features/Stake/Tests/ViewModels/StakeSceneViewModelTests.swift
  • Updated import statements to include StakeTestKit and reordered Store import.
  • Removed the inline StakeSceneViewModel mock extension and its associated //TODO.
  • Added a new @Test function recommendedCurrentValidator to verify the deterministic selection of the recommended validator.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a good improvement by replacing a random validator selection with a deterministic lookup, enhancing predictability and efficiency. The addition of a TestKit for StakeSceneViewModel is a great step towards better test maintainability by centralizing mock object creation. The tests have been updated to use this new TestKit, and a new unit test has been added for the updated logic. I have one suggestion to make the new test more robust by avoiding a potential crash. Overall, this is a solid contribution.