Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

Adapt Swapper change in core#1770

Merged
gemcoder21 merged 1 commit intomainfrom
update-core2
Mar 5, 2026
Merged

Adapt Swapper change in core#1770
gemcoder21 merged 1 commit intomainfrom
update-core2

Conversation

@0xh3rman
Copy link
Copy Markdown
Contributor

@0xh3rman 0xh3rman commented Mar 5, 2026

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the SwapService by updating method names to reflect a change in the core swapper component. The fetchQuote and fetchQuoteData methods were renamed to getQuote and getQuoteData to maintain consistency with the updated API, ensuring the service correctly interacts with the modified dependency.

Highlights

  • Method Renaming: The fetchQuote and fetchQuoteData methods within the SwapService have been renamed to getQuote and getQuoteData respectively, to align with changes in the underlying swapper dependency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adapts SwapService to recent changes in the core swapper dependency, renaming fetchQuote to getQuote and fetchQuoteData to getQuoteData. While these changes are correct, the corresponding test mock, GemSwapperMock, has not been updated to reflect the protocol changes. This will likely cause compilation errors in the test suite. It's important to update all implementations of the GemSwapperProtocol, including mocks, to ensure the codebase remains consistent and tests can pass.

@gemcoder21 gemcoder21 merged commit 1a79f59 into main Mar 5, 2026
1 check passed
@gemcoder21 gemcoder21 deleted the update-core2 branch March 5, 2026 05:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants